[VL] Reduce triple map lookup to single find in dictionary serialization#11628
Merged
marin-ma merged 1 commit intoapache:mainfrom Mar 2, 2026
Merged
Conversation
Contributor
Author
|
@marin-ma can you please review this PR? Thanks in advance! |
| auto it = dictionaries_.find(fieldIdx); | ||
| GLUTEN_DCHECK( | ||
| dictionaries_.find(fieldIdx) != dictionaries_.end(), | ||
| it != dictionaries_.end(), |
Contributor
There was a problem hiding this comment.
GLUTEN_DCHECK means the code only executes on debug compilation mode, so we don't need to add complexity for it. Only if the code logic has something wrong, the check mai fail.
Contributor
There was a problem hiding this comment.
@jinchengchenghh This change makes sense as dictionaries_.erase(fieldIdx) also performs another lookup.
marin-ma
approved these changes
Mar 2, 2026
Contributor
marin-ma
left a comment
marin-ma
left a comment
There was a problem hiding this comment.
LGTM. Sorry for the late review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
This PR replaces three separate map look ups on the same key with a single
find()and iterator reuse inArrowShuffleDictionaryWriter::serialize()How was this patch tested?
Existing UTs
Was this patch authored or co-authored using generative AI tooling?
No